Breaking: get rid of index

[tiemvanderdeure]

index is removed in DD 0.30, so we might as well get rid of it already.

Makes it much easier to test the breaking branch of DD without running into these silly errors (you're welcome).

[codecov]

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.75%. Comparing base (f1c4b75) to head (56518e1).
⚠️ Report is 49 commits behind head on main.

Files with missing lines	Patch %	Lines
src/lookup.jl	40.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1029      +/-   ##
==========================================
+ Coverage   82.89%   83.75%   +0.85%     
==========================================
  Files          58       68      +10     
  Lines        5425     5472      +47     
==========================================
+ Hits         4497     4583      +86     
+ Misses        928      889      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rafaqz]

Really need to switch to parent(lookup(d)) not lookup(d) esp with plotting.

Lets avoid any complications and responsibities by returning types we dont own .

[tiemvanderdeure]

projectedindex isn't API, is it? Should we rename it projectedlookup or something for consistency?

[rafaqz]

Yeah projectedlookup is good

[tiemvanderdeure]

Should that return a Lookup? Then we can just define projectedlookup(dim::Dimension) = reproject(crs(dim), lookup(dim))

And similar for mappedindex, I guess?

[rafaqz]

Honestly Im not sure, you will need to look at how they are used

[tiemvanderdeure]

They don't really seem to be used at all? Both of them are exported and mappedindex has a docstring of a few lines but they aren't called internally anywhere and mappedindex is untested and also not mentioned in the docs.

I can only find one public repo on github where mappedindex is used, all the other ones are rasters forks: https://github.com/search?q=language%3AJulia+AND+%28%22mappedindex%28%22+OR+%22projectedindex%28%22%29&type=code&ref=advsearch

Since reproject does the same thing we could also just remove these functions.

[rafaqz]

Ok delete away