Skip to content

Conversation

@sdjnes
Copy link

@sdjnes sdjnes commented Nov 25, 2025

No description provided.

@sdjnes sdjnes requested a review from a team as a code owner November 25, 2025 11:17
@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for suse-obs ready!

Name Link
🔨 Latest commit ecd3c7b
🔍 Latest deploy log https://app.netlify.com/projects/suse-obs/deploys/69287dacb9ffbc00082418a9
😎 Deploy Preview https://deploy-preview-134--suse-obs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.


Next to the three dots icon, there is an icon to open the widget in the metric inspector drawer. This allows you to inspect the data of the widget in more detail.

// TODO STAC-22767 Add screenshot of the dropdown menu? No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say yes. With the steps getting quite nested, an image would help.

Copy link
Contributor

@akashraj4261 akashraj4261 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suggested a few aesthetic changes as well as sentence structural changes as per SUSE styleguide. Do let me know if you do not agree or find anything not feasible.

Thanks.

* Widget queries, links
* TODO STAC-22767 - list other places?

To use a variable in a compatible field, use the variable name preceded by a `$` (for example, `$my_variable`). The value of the variable is interpolated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To use a variable in a compatible field, use the variable name preceded by a `$` (for example, `$my_variable`). The value of the variable is interpolated.
To use a variable in a compatible field, use the variable name wrapped in a `${}` (for example, `${my_variable}`). The value of the variable is interpolated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would help to also show a screenshot for a widget where a variable like cluster (at least a meaningful variable, ideally the one that is used in the previous screenshot) is used in the Promql query.

. Open the "Edit dashboard variables" drawer.
. Click the "Add variable" button to open a second drawer where you can configure the new variable.

// TODO STAC-22767 Add a screenshot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A screenshot that uses a recognizable variable that's already entirely configured would make the most sense I think. For example a cluster variable that uses the cluster_name label. Possibly including a series selector to limit it to something like kubernetes_state_pod_age.

| Allow multiple values
| Allow users to select more than one value at a time.

| Enable "Include Everything" option
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For both the multiple and the everything option we need to document that it produces a regex during interpolation so it should be used with the Promql regex matcher: =~.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added an additional section that talks about how variables are interpolated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants