-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Overlays: add overlay for rak-6421 WisBlock hat #7142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5767df2 to
e8df8a8
Compare
|
@pelwell I saw the failing tests, and fixed up the two issues: Replaced the spaces with tabs, and added the longer commit message to the commit itself. |
e8df8a8 to
3b62f9a
Compare
|
The dtoverlay check will fail for 2 reasons:
|
3b62f9a to
48ace49
Compare
|
@pelwell Ah-hah! I think those are fixed now. Thanks! |
|
|
Add a comment when you've done that and I'll restart the workflow. |
48ace49 to
84bd21c
Compare
I can't imagine why someone would want/need to override any of the three values I left in overrides, so I've just yanked that section. Do I still need the |
|
What you are left with doesn't make sense. If you need the MISO line, delete fragment 3. If you don't need the MISO line, change it from |
The RAK 6421 is a new HAT+ device for Meshtastic, that adds support for the WisBlock ecosystem on the Raspberry Pi. This overlay will usually be loaded via the HAT+ eeprom. Signed-off-by: Jonathan Bennett <[email protected]>
84bd21c to
e23b1a3
Compare
|
@pelwell Thanks for the handholding on this. I've removed fragment 3, and tested the result with real hardware. It still fires up the i2c and SPI busses as expected. |
|
Your overlay looks OK now, but it is setting some properties to their default values. If you take out this duplication, you are left with: which is the equivalent of: I'm not sure if this made it into the documentation, but the overlay name string can include parameters (separated from the overlay name by commas, as in config.txt). And as with config.txt DT parameters, any which aren't found in the overlay are then matched against the base dtb. This means that: and: are equivalent. If the Finally, for the last year and half, the firmware has supported a magic overlay name - "none". This means that will always enable the board's SPI parameter. Putting these pieces together, you should be able to completely eliminate your overlay (if you want to), by making the string in the EEPROM: I suggest you give it a try, and let me know what you want to do. |
That works! This is basically all I wanted to do, but didn't find that "none" magic overlay anywhere. I'll go ahead and close this. Thank you so much for your help @pelwell ! |
The RAK 6421 is a new HAT+ device for Meshtastic, that adds support for the WisBlock ecosystem on the Raspberry Pi. This overlay will usually be loaded via the HAT+ eeprom.