Skip to content

Conversation

@AdamSaleh
Copy link

Making the RemoveEnv method work across all containers in a deployment, instead asserting there is exactly one container.

What type of PR is this?
/kind failing-test

What does this PR do / why we need it:

When installing gitops-operator-bundle directly through operator sdk, there seems to be more than one container in the deployment. Making the utility function work across all containers makes the code more robust.

@openshift-ci openshift-ci bot added the kind/failing-test Categorizes issue or PR as related to a frequently failing test. label Nov 10, 2025
@openshift-ci openshift-ci bot requested review from jgwest and svghadi November 10, 2025 10:04
@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jannfis for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2025

Hi @AdamSaleh. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@svghadi
Copy link
Member

svghadi commented Nov 10, 2025

/ok-to-test

@jgwest
Copy link
Member

jgwest commented Nov 12, 2025

/retest

1 similar comment
@AdamSaleh
Copy link
Author

/retest

@AdamSaleh AdamSaleh force-pushed the rm_env_across_containers branch from aa8b86c to 75cdcc6 Compare November 19, 2025 13:27
@AdamSaleh AdamSaleh force-pushed the rm_env_across_containers branch from 75cdcc6 to 4a1c437 Compare November 19, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/failing-test Categorizes issue or PR as related to a frequently failing test. ok-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants