Print version information when using --version flag #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acornett21
requested changes
Dec 1, 2025
Contributor
acornett21
left a comment
acornett21
left a comment
There was a problem hiding this comment.
It probably makes sense to make /version its own package, and carry over the tests as well.
caxu-rh
force-pushed
the
add-version-flag
branch
from
1502c16 to
4f77797
Compare
Signed-off-by: Caleb Xu <[email protected]>
caxu-rh
force-pushed
the
add-version-flag
branch
from
4f77797 to
40d8b5f
Compare
acornett21
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versionfield inrootCmdto point at this version struct (similar to Preflight)RELEASE_TAGwhen building container image to ensure that version information is passed to Makefile (and then togo build)This PR addresses #87.