Change logging on disk behavior to stick to validations spec #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding callback plugins, because the libs needs it for log creations and output on the filesystem. The libs needs to be autonomus.
strider
reviewed
Mar 11, 2020
| @@ -0,0 +1,31 @@ | |||
| #!/usr/bin/env python | |||
Member
There was a problem hiding this comment.
These callbacks should stay in validations-common which will be a dependency of validations-libs.
strider
requested changes
Mar 11, 2020
Member
strider
left a comment
strider
left a comment
There was a problem hiding this comment.
The callbacks should stay in validations-common.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.