chore: update walletconnect dependencies to 2.23.0 #5298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated @walletconnect/core from 2.22.4 to 2.23.0 - Updated @walletconnect/sign-client from 2.22.4 to 2.23.0 - Updated @walletconnect/types from 2.22.4 to 2.23.0 - Updated @walletconnect/utils from 2.22.4 to 2.23.0 - Updated @walletconnect/react-native-compat from 2.22.4 to 2.23.0 - Updated @walletconnect/ethereum-provider from 2.22.4 to 2.23.0 - Updated @walletconnect/universal-provider from 2.22.4 to 2.23.0 - Updated @walletconnect/signer-connection from 2.22.4 to 2.23.0 Fixed TypeScript compatibility issues: - Made Cacao.Payload.aud optional in SIWXUtil.ts to match updated types - Made CacaoPayload.aud optional in siwe TypeUtils.ts to match updated types Source: WalletConnect/walletconnect-monorepo@cf822b5 Co-Authored-By: unknown <>
|
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Visual Regression Test Results ✅ Passed✨ No visual changes detected Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=262 |
Contributor
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/[email protected] size /home/runner/work/appkit/appkit > size-limit |
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates WalletConnect dependencies to version 2.23.0 across the monorepo following the upstream release.
Updated Packages
The following WalletConnect packages were updated from 2.22.4 to 2.23.0:
@walletconnect/sign-client@walletconnect/types@walletconnect/universal-provider@walletconnect/utils@walletconnect/ethereum-providerType Compatibility Changes
The upstream 2.23.0 release changed the
Cacao.Payload.audfield from a required string to an optional string. To maintain type compatibility, updated two local interface definitions:packages/controllers/src/utils/SIWXUtil.ts:707
packages/siwe/core/utils/TypeUtils.ts:33
The authentication logic in SIWXUtil.ts now explicitly handles the optional
audfield with a fallback:uri: cacao.p.aud || ''Type of change
CI Status
✅ Passing checks:
❌ Failing checks:
Associated Issues
Automated dependency update triggered by upstream release: WalletConnect/walletconnect-monorepo@cf822b5
Checklist
Link to Devin run: https://app.devin.ai/sessions/d73f92f8ce8449999c5418c343450052
Requested by: unknown ()
Preview deployment: https://vercel.com/reown-com/appkit-laboratory/5V3DkEXoNGFCG1dBtU3fbNB4E8bo
Human Review Checklist
🔍 Critical areas to review:
Cacao.Payload.audoptional is safe throughout the codebase - search for all usages of this field to ensure no code assumes it's always present