Send Authorization header irrespective of previous authentication status (#178) #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chamakuri-vineel
commented
Sep 1, 2023
chamakuri-vineel
commented
- Currently 'force_preemptive' flag sends the 'Authorization' header only for the first call and not for subsequent calls. This is because 'Authorization' header is preemptively sent only if the request is not authenticated. The status of authentication is stored as 'auth_done' instance variable. Since all the HTTP calls use the same instance of HTTPKerberosAuth class the 'auth_done' instance variable is set to True after first successful authentication and thus 'Authorization' header is not set preemptively after that.
- The fix is to send the Authorization header irrespective of the authentication status of previous call.
Author
|
@mkomitee @josecastroleon @dpursehouse please review the PR. This is to fix #178 issue. |
…tus (requests#178) - Currently 'force_preemptive' flag sends the 'Authorization' header only for the first call and not for subsequent calls. This is because 'Authorization' header is preemptively sent only if the request is not authenticated. The status of authentication is stored as 'auth_done' instance variable. Since all the HTTP calls use the same instance of HTTPKerberosAuth class the 'auth_done' instance variable is set to True after first successful authentication and thus 'Authorization' header is not set preemptively after that. - The fix is to send the Authorization header irrespective of the authentication status of previous call.
chamakuri-vineel
force-pushed
the
master
branch
from
9a05cb6 to
318fd99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.