-
-
Notifications
You must be signed in to change notification settings - Fork 254
refactor: simplify sidebarlayout and removed nested divs #1156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Deploying rescript-lang-org with
|
| Latest commit: |
a634c9e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ce5b3d09.rescript-lang.pages.dev |
| Branch Preview URL: | https://vlk-fix-sidebarlayout-overfl.rescript-lang.pages.dev |
|
Hmmm, is the smaller left padding deliberate? |
Nope, I have a few things to cleanup. |
…nto vlk/fix-sidebarlayout-overflow
Fixed. |
|
Ah so you wanted to put the sidebar actually on the side now? |
Moving it to the side wasn't intended. I was simplifying some of the divs to address content overflowing at different break points. It shouldn't look too different from prod right now. |
…nto vlk/fix-sidebarlayout-overflow



There were a lot of extra divs leading to some layout wonkiness at different screen sizes.
Before
After