Skip to content

Conversation

@jderochervlk
Copy link
Collaborator

@jderochervlk jderochervlk commented Dec 1, 2025

There were a lot of extra divs leading to some layout wonkiness at different screen sizes.

Before

image

After

image

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 1, 2025

Deploying rescript-lang-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: a634c9e
Status: ✅  Deploy successful!
Preview URL: https://ce5b3d09.rescript-lang.pages.dev
Branch Preview URL: https://vlk-fix-sidebarlayout-overfl.rescript-lang.pages.dev

View logs

@jderochervlk jderochervlk changed the title fix: fix overflow for sidebar layout refactor: simplify sidebarlayout and removed nested divs Dec 1, 2025
@fhammerschmidt
Copy link
Member

Hmmm, is the smaller left padding deliberate?

@jderochervlk jderochervlk marked this pull request as draft December 1, 2025 14:24
@jderochervlk
Copy link
Collaborator Author

Hmmm, is the smaller left padding deliberate?

Nope, I have a few things to cleanup.

@jderochervlk
Copy link
Collaborator Author

Hmmm, is the smaller left padding deliberate?

Fixed.

@jderochervlk jderochervlk marked this pull request as ready for review December 1, 2025 15:16
@fhammerschmidt
Copy link
Member

Ah so you wanted to put the sidebar actually on the side now?
Regardless, the content ist left-aligned as well now, not sure that is an improvement.

@jderochervlk jderochervlk marked this pull request as draft December 1, 2025 15:20
@jderochervlk
Copy link
Collaborator Author

Ah so you wanted to put the sidebar actually on the side now? Regardless, the content ist left-aligned as well now, not sure that is an improvement.

Moving it to the side wasn't intended. I was simplifying some of the divs to address content overflowing at different break points. It shouldn't look too different from prod right now.

@jderochervlk jderochervlk marked this pull request as ready for review December 1, 2025 15:55
@jderochervlk jderochervlk marked this pull request as draft December 1, 2025 15:58
@jderochervlk jderochervlk marked this pull request as ready for review December 1, 2025 16:06
@fhammerschmidt
Copy link
Member

image

Almost! Text needs some padding on the left.

@jderochervlk
Copy link
Collaborator Author

image

Almost! Text needs some padding on the left.

Done! I also made some padding tweaks for smaller screens to remove some of the extra whitespace on tablets and large phones.

@fhammerschmidt
Copy link
Member

I now have this weird glitch
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants