-
Notifications
You must be signed in to change notification settings - Fork 474
Add script for tagging all npm packages for a release #8041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5bd217d to
d9efe69
Compare
tsnobip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice improvement!
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
| 1. Run `npm info rescript` to verify that the new version is now present with tag "ci". | ||
| 1. Test the new version. | ||
| 1. Tag the new version as appropriate (`latest` or `next`): `npm dist-tag add rescript@<version> <tag>` | ||
| 1. Tag all packages for the new version as appropriate (`latest` or `next`): `./scripts/npmRelease.js --version <version> --tag <tag>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the lore here that this is such a labor intensive process?
Just curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Labor intensive, well, you should have seen how these processes worked in earlier times. 🙈
The current procedure allows one to test the finished packages for a final time using npm install rescript@ci, and then decide manually which tag to set.
Ideas for further simplification/automation are of course welcome. If the final tag latest/next is to be set by CI automatically on a tag build (instead of just the ci tag), it needs to know 100% when to use what, and especially avoid publishing versions from maintenance branches as next/latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, I could be wrong, but that sounds like a bit of conditional logic in a script?
npm view rescript --json can show the current latest, ci, next tags.
If a maintenance branch needs to publish another 11, it can detect that a higher major exists. Stuff like that.
Again, I'm unfamiliar with what we are trying to achieve in the first place.
No description provided.