Fixed issue #483 #536
Open
Fixed issue #483 #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * By automatically freeing memory Rust helps ensure that there are fewer | ||
| memory leaks. | ||
| * Rust ensures safe and predictable cleanup by dropping fields before the |
Contributor
There was a problem hiding this comment.
This is incorrect, please take a look at the Drop trait.
| content_markdown: > | ||
| When a struct is dropped, the struct itself is dropped first, then its | ||
| children are dropped individually, and so on. | ||
| When a struct is dropped, its fields (children) are dropped first, in the |
Contributor
There was a problem hiding this comment.
This is incorrect, take a look at the Drop trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original explanation of Rust's dropping behavior contained an error that could lead to misunderstandings:
It stated that "the struct itself is dropped first, then its children are dropped individually". This is incorrect because Rust ensures that fields (children) are dropped first, followed by the struct itself.
The explanation also lacked an example to demonstrate the correct behavior, which could help clarify this important concept for readers.