Support Sonatype username+token #193
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks @svdo! This week has been really busy so far, but I'll try to look at this soon! |
Contributor
|
May I suggest to also allow passing the credentials in via environment variables as is already the case for the NVD API token? That would make it easier to manage them in a CI environment. |
Collaborator
|
@svdo I've pulled your work into #194, as I need it in a branch in this repo for the integration tests to run. I've included being able to set them via env variables @DerGuteMoritz. I hope to get this released soon (today or this weekend). |
Author
|
You're the best, great! 😊 |
Collaborator
|
This was released in 5.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192.
I set it to "draft" because I'm not sure if this needs more changes in terms of your own development/deployment process.
Feedback welcome @tobias!