[hist] Implement initial RHistConcurrentFiller
#20555
Open
+396
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 20h 21m 50s ⏱️ Results for commit 4eff656. ♻️ This comment has been updated with latest results. |
hahnjo
force-pushed
the
hist-concurrent
branch
from
f523d62 to
b1c4939
Compare
hageboeck
reviewed
Dec 2, 2025
| /// Create a new context for concurrent filling. | ||
| std::shared_ptr<RHistFillContext<BinContentType>> CreateFillContext() | ||
| { | ||
| std::lock_guard g(fMutex); |
Member
There was a problem hiding this comment.
One could maybe use the c++17 alternative:
Suggested change
| std::lock_guard g(fMutex); | |
| std::scoped_lock g(fMutex); |
Member
Author
There was a problem hiding this comment.
As far as I understand, std::lock_guard is preferable for exactly one mutex.
hageboeck
approved these changes
Dec 2, 2025
hahnjo
force-pushed
the
hist-concurrent
branch
from
b1c4939 to
2ff8e2a
Compare
In order to support efficient concurrent filling of RHist with global histogram statistics, we keep one local RHistStats object per RHistFillContext.
hahnjo
force-pushed
the
hist-concurrent
branch
from
2ff8e2a to
4eff656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support efficient concurrent filling of
RHistwith global histogram statistics, we keep one localRHistStatsobject perRHistFillContext.