Store the built Ruby commit sha in the github env #154
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we expected "docker run image" to return the ruby sha but it does not. When we build the tags for the manifest we try and fetch the commit hash from the environment, falling back to getting the latest commit from master if it's empty (which it will be in this case). So this means there is a window between when the image builds happen and when the deploy_multiarch job happens where if HEAD advances then a tagged image will be built containing the incorrect Ruby version. This is made more likely if there's a build failure (eg. for ephemeral apt reasons), because the time delta between the images are built and when deploy_multiarch gets the sha and creates the manifest gets larger. The effect of this bug can be seen by examining the output of the 20251202 image builds where: - The dated image is built with a particular sha - The commit tagged image doesn't exist - A tagged image from a later commit exists, and contains the actually built sha. ``` ❯ docker run -it rubylang/ruby:master-20251202 ruby -e 'puts RUBY_REVISION' 0e22108d60fbd0e338fb6e110ddd81a93b45b592 ~/git/docker-images master* ❯ docker run --rm rubylang/ruby:master-0e22108d60fbd0e338fb6e110ddd81a93b45b592 ruby -e 'puts RUBY_REVISION' Unable to find image 'rubylang/ruby:master-0e22108d60fbd0e338fb6e110ddd81a93b45b592' locally ~/git/docker-images master* ❯ docker run --rm rubylang/ruby:master-456ba321a84d34e76c8837ac96f47a11457480cb ruby -e 'puts RUBY_REVISION' 0e22108d60fbd0e338fb6e110ddd81a93b45b592 ```
tekknolagi
approved these changes
Dec 2, 2025
|
I think this happened again: rubybench/rubybench-data@aef07d5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we expected "docker run image" to return the ruby sha but it does not.
When we build the tags for the manifest we try and fetch the commit hash from the environment, falling back to getting the latest commit from master if it's empty (which it will be in this case).
So this means there is a window between when the image builds happen and when the deploy_multiarch job happens where if HEAD advances then a tagged image will be built containing the incorrect Ruby version.
This is made more likely if there's a build failure (eg. for ephemeral apt reasons), because the time delta between the images are built and when deploy_multiarch gets the sha and creates the manifest gets larger.
The effect of this bug can be seen by examining the output of the 20251202 image builds where: