Skip to content

Improve irb_spec's home setup #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve irb_spec's home setup #1141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bd6a47
Improve irb_spec's home setup
st0012 Mar 7, 2024
23927d1
Remove unneeded fixture file
st0012 Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion core/binding/fixtures/irbrc
View file
Open in desktop

This file was deleted.

12 changes: 10 additions & 2 deletions core/binding/irb_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
require_relative '../../spec_helper'

describe "Binding#irb" do
before :each do
@env_home = ENV["HOME"]
Copy link
Member

@nobu nobu Mar 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@env_home = ENV["HOME"]
@envs = ["IRBRC", "XDG_CONFIG_HOME", "HOME"].map {|e| [e, ENV.delete(e)]}.to_h

ENV["HOME"] = CODE_LOADING_DIR
end

after :each do
ENV["HOME"] = @env_home
Copy link
Member

@nobu nobu Mar 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ENV["HOME"] = @env_home
ENV.update(@envs)

end

it "creates an IRB session with the binding in scope" do
irb_fixture = fixture __FILE__, "irb.rb"
irbrc_fixture = fixture __FILE__, "irbrc"

out = IO.popen([{"IRBRC"=>irbrc_fixture}, *ruby_exe, irb_fixture], "r+") do |pipe|
out = IO.popen([*ruby_exe, irb_fixture], "r+") do |pipe|
Copy link
Member

@nobu nobu Mar 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather how about to change states only in the IO.popen-ed process?

Suggested change
out = IO.popen([*ruby_exe, irb_fixture], "r+") do |pipe|
dir = CODE_LOADING_DIR
envs = {"IRBRC" => nil, "XDG_CONFIG_HOME" => nil, "HOME" => dir}
out = IO.popen([envs, *ruby_exe, irb_fixture, chdir: dir], "r+") do |pipe|

pipe.puts "a ** 2"
pipe.puts "exit"
pipe.readlines.map(&:chomp)
Expand Down