Fix checks and their ordering in some proofs, update mir-semantics dependency #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stevengre
approved these changes
Dec 6, 2025
dkcumming
approved these changes
Dec 6, 2025
Collaborator
dkcumming
left a comment
dkcumming
left a comment
There was a problem hiding this comment.
Sorry for the incorrect error code, I don't remember doing that but it was 100% me that did it.
Co-authored-by: Daniel Cumming <[email protected]>
Stevengre
added a commit
that referenced
this pull request
Dec 8, 2025
jberthold
pushed a commit
that referenced
this pull request
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withdraw_excess_lamports_accountused a wrong error code for the overflow casewithdraw_excess_lamports_mintskipped checking overflow errors when the mint auth flag was settransfer_checkedhad a strayassert(result.is_ok())placed before some error checksclose_accountskipped checking for overflow when the account was owned by system or incineratorAlso updates the
mir-semanticsdependency to the latest feature branch.