Move the util bin to a package #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also reorganizes the dependencies and the feature flags (note that it doesn't update them) The only dependecy changed is embedded_hal which is set to use the exact 1.0.0-alpha.5 version This is because Cargo started using the *.8 version which conflicted with the radio crate own dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the utility binary in a stand-alone package (based on the main lib).
I feel like this makes for a better dependency handling with the features related to the library separated from the ones related to the binary.
I made this change while trying to figure out how to solve some compile errors related to dependencies that had different version of a common crate.
In the end the errors turned out to be caused only by the embedded-hal crate which should have been declared with a stronger version bound (now set to
=1.0.0-alpha.5)