Skip to content

fix(dist/manifestation): print "downloading component" only on InstallEvents #4625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rami3l merged 2 commits into from
Nov 27, 2025
Merged

fix(dist/manifestation): print "downloading component" only on InstallEvents #4625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbc3119
fix(dist/manifestation): print "downloading component" only on `Insta…
rami3l Nov 27, 2025
c39ba5b
chore(config): remove redundant imports
rami3l Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use std::str::FromStr;
use anyhow::{Context, Result, anyhow, bail};
use serde::Deserialize;
use thiserror::Error as ThisError;
use tracing::{debug, error, info, trace, warn};
use tracing::{debug, info, trace, warn};
Copy link
Member Author

@rami3l rami3l Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why this wasn't linted before. Toolchain bug?


use crate::{
cli::{common, self_update::SelfUpdateMode},
Expand Down
2 changes: 1 addition & 1 deletion src/dist/manifestation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,8 @@ impl Manifestation {
tx = self.uninstall_component(component, &new_manifest, tx)?;
}

info!("downloading component(s)");
let mut tx = if !components.is_empty() {
info!("downloading component(s)");
let mut stream = InstallEvents::new(components.into_iter(), Arc::new(self));
let mut transaction = Some(tx);
let tx = loop {
Expand Down