fix(dist/download): align total_bytes fields in progress reporting UI
#4629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4604, the
total_bytesfields seem to be inconsistently left-aligned in some places, and right-aligned in others. As such, scenarios like the following will occur from time to time (note thecargoline):Thus, it is required to make them right-aligned with
:>, however it seems (from my testing) that specifying the alignment without a width is a no-op, so a width of1011 is deduced from the longest string from my observation123.45 MiB1023.00 KiB.However, since the rest of the codebase assumes a width of 9, I have manually increased every appearance of explicit width by a value of
12 for the sake of coherence.This gives something like: