test(static-roots): refine store_static_roots()
#4634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
force-pushed
the
test/static-root-refine
branch
from
36c8ee6 to
d66d9d4
Compare
djc
approved these changes
Dec 8, 2025
rami3l
force-pushed
the
test/static-root-refine
branch
from
d66d9d4 to
a301230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #4631 (comment).
This PR also tries to find a better way to fit the raw binaries. The b-string syntax is what I can think of as a better alternative for now...
PS:
What is the column limit on our formatter again?100, so fitting 20\xabs in one line does sound reasonable.