Implement BlockIO2 #1841
Merged
Implement BlockIO2 #1841
+171
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
requested changes
Dec 3, 2025
Member
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I un-checked Sensible git history tho ;)
Your PR should have two commits:
uefi-raw: add BlockIo2 protocoluefi: add BlockIo2 protocol wrapper
Contributor
Author
|
Thanks for the review, I updated the commits as you requested. |
phip1611
reviewed
Dec 6, 2025
| &mut self, | ||
| media_id: u32, | ||
| lba: Lba, | ||
| token: Option<NonNull<BlockIO2Token>>, |
Member
There was a problem hiding this comment.
to me the Option<NonNull<T>> looks a little weird and not very idiomatic. However, it is used in lots of places of the code base, so its fine with me.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
phip1611
approved these changes
Dec 6, 2025
Member
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
Great contribution, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the Block I/O 2 Protocol
Checklist