Skip to content

Fix seg fault when using cookie based auth on 64 bit system #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix seg fault when using cookie based auth on 64 bit system #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51562a7
%lld was for long long int was causing segmentation faults when using…
Sep 29, 2011
f48b9ba
Earlier commit changed it to %lld to %ld for printing time. After bro…
Sep 30, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mod_auth_remote.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ static char *auth_remote_signature(apr_pool_t *p, const char *user, apr_int64_t
int blen = apr_base64_encode_len(APR_MD5_DIGESTSIZE);
unsigned char md5[APR_MD5_DIGESTSIZE];
char *md5_b64 = apr_palloc(p, blen);
char *s = apr_psprintf(p, "%s:%lld:%s", user, curr, salt);
char *s = apr_psprintf(p, "%s:%" APR_TIME_T_FMT ":%s", user, curr, salt);

apr_md5(md5, s, strlen(s));
apr_base64_encode_binary(md5_b64, md5, APR_MD5_DIGESTSIZE);
Expand Down Expand Up @@ -188,7 +188,7 @@ static short auth_remote_validate_cookie(request_rec *r, const char *exp_user, c
static void auth_remote_set_cookie(request_rec *r, const char *user, auth_remote_config_rec *conf)
{
apr_time_t now = apr_time_sec(apr_time_now());
char *cookie = apr_psprintf(r->pool, "%s=%s^%lld^%s;path=%s", conf->cookie_name, user, now,
char *cookie = apr_psprintf(r->pool, "%s=%s^%" APR_TIME_T_FMT "^%s;path=%s", conf->cookie_name, user, now,
auth_remote_signature(r->pool, user, now, auth_remote_salt),
conf->cookie_path);
apr_table_addn(r->err_headers_out, "Set-Cookie", cookie);
Expand Down