This repository was archived by the owner on Jan 20, 2024. It is now read-only.
Update savon to ~> 2.3 #112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per savonrb/savon#518, changes to Savon causes the gem to break in version of Savon beyond 2.2. This is a first pass at moving all the attribute parsing to the new behavior.
# Conflicts: # lib/marketingcloudsdk/soap.rb # spec/soap_spec.rb From johnadamson/FuelSDK-Ruby per savonrb/savon#518 and salesforce-marketingcloud#7
hopefully reduces pain with various later versions now that we are compatible with 2.3
|
Savon 2.12.1 is out and works without major changes. See #115 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates the updates mentioned in #7 to the 1.3.0 branch.
edit: This certainly will need a version bump, but I noticed the version is sent in user agent, so I'd rather get some feedback from maintainers on preference before bumping.