-
Notifications
You must be signed in to change notification settings - Fork 134
feat: add CorrT1METJet to NanoAOD schema and also add zero TrigObj mass #1480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@nsmith- Is it safe to add zero mass to the trigobj 4-vector to allow 4-vector math? Also |
| # Alias CorrT1METJet_rawPt to CorrT1METJet_pt and add zero mass for CorrT1METJet collection | ||
| if "oCorrT1METJet" in branch_forms: | ||
| if "CorrT1METJet_pt" not in branch_forms: | ||
| branch_forms["CorrT1METJet_pt"] = branch_forms["CorrT1METJet_rawPt"] | ||
| if "CorrT1METJet_mass" not in branch_forms: | ||
| branch_forms["CorrT1METJet_mass"] = transforms.zeros_from_offsets_form( | ||
| branch_forms["oCorrT1METJet"] | ||
| ) | ||
|
|
||
| # Add zero mass to the trigger objects | ||
| if "oTrigObj" in branch_forms: | ||
| if "TrigObj_mass" not in branch_forms: | ||
| branch_forms["TrigObj_mass"] = transforms.zeros_from_offsets_form( | ||
| branch_forms["oTrigObj"] | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these explicit stuff will be refactored in the form of class variable dictionaries similar to how we define all the other mixins. It will be done as part of closing #1474. I'm just now doing it in the same pattern as everything else.
|
I don't understand this flaky failure that just showed up...... |
|
Yeah this currently works but I had to add a big chunk of slightly modified code that I stole from awkward array in order to keep tracing functioning properly....This functionality should probably be in awkward and not here. |

Closes #1119