Skip to content

Conversation

@matthewfeickert
Copy link
Member

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.51%. Comparing base (8c71761) to head (d0796ab).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   72.51%   72.51%           
=======================================
  Files           4        4           
  Lines         131      131           
=======================================
  Hits           95       95           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matthewfeickert
Copy link
Member Author

cc @henryiii for review as he was the last to touch this segment of the README and added the CLI options in PR #51.

* As installation creates the executables 'bin/scikit-hep-testdata' and
  'bin/skhep-testdata', demonstrate these in the README rather than running
  the module as a script with '-m'.
   - c.f. https://docs.python.org/3/using/cmdline.html#cmdoption-m
* Show how to use 'uvx', 'pipx', and 'pixi exec' to be able to access and use
  the CLI API without having to explicitly install into an environment.

* uv:

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```bash

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bash syntax highlighting on GitHub looks the same as no syntax highlighting on GitHub if you aren't using explicit Bash commands. I would normally suggest console, as that's more correct as people will be executing these in shells regardless of shell type, but that does change the syntax highlighting in a way that just converts all of it to a new color, which isn't very useful.

Is there an advantage to selecting bash here? If no, should we change Scikit-HEP style recommendations?


* pipx:

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```bash


* Pixi:

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```bash

Copy link
Member

@eduardo-rodrigues eduardo-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants