Skip to content

Conversation

@bsneed
Copy link
Contributor

@bsneed bsneed commented Oct 14, 2025

  • Start looking for server side settings config
  • Disable signal transfers if it's disabled.
  • Plumbing for sampleRate present, but unused.

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 77.14286% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.60%. Comparing base (39d684e) to head (17d5986).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...alyticsLive/Signals/Minilytics/MiniAnalytics.swift 59.09% 9 Missing ⚠️
Sources/AnalyticsLive/Signals/Signals.swift 87.50% 4 Missing ⚠️
...Live/Signals/Broadcasters/SegmentBroadcaster.swift 62.50% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (77.14%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (37.60%) is below the target coverage (50.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   36.02%   37.60%   +1.57%     
==========================================
  Files          38       38              
  Lines        3270     3303      +33     
==========================================
+ Hits         1178     1242      +64     
+ Misses       2092     2061      -31     
Files with missing lines Coverage Δ
...ources/AnalyticsLive/LivePlugins/LivePlugins.swift 94.62% <100.00%> (+2.73%) ⬆️
Sources/AnalyticsLive/Signals/Configuration.swift 94.28% <100.00%> (+0.34%) ⬆️
Sources/AnalyticsLive/Signals/Types.swift 80.00% <ø> (ø)
...s/AnalyticsLive/Signals/Utilities/Extensions.swift 57.57% <100.00%> (+0.24%) ⬆️
...Live/Signals/Broadcasters/SegmentBroadcaster.swift 60.86% <62.50%> (-17.40%) ⬇️
Sources/AnalyticsLive/Signals/Signals.swift 82.97% <87.50%> (-0.75%) ⬇️
...alyticsLive/Signals/Minilytics/MiniAnalytics.swift 45.67% <59.09%> (+2.45%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bsneed bsneed merged commit c28ffe3 into main Oct 15, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants