-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[Fix] add block size logic for sm120 smem size #14311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update block size assignments for consumer Blackwell sm120 architecture.
Summary of ChangesHello @koush, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical resource allocation issue on consumer Blackwell sm120 GPUs by refining the block size calculations for the attention mechanism. The changes ensure that the system operates within the hardware's shared memory constraints, preventing runtime failures and improving stability on these specific architectures. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the block size assignments for the sm120 (Blackwell) architecture to resolve an 'out of resource: shared memory' error. The changes introduce specific block sizes for this architecture, which are appropriate given its shared memory constraints. The logic is correct. My review includes a suggestion to refactor the conditional logic for checking CUDA capabilities to improve code structure and maintainability.
python/sglang/srt/layers/attention/triton_ops/extend_attention.py
Outdated
Show resolved
Hide resolved
|
Fixes #14322 |
Update block size assignments for consumer Blackwell sm120 architecture.
Motivation
Kimi K2 thinking crashes after the first request on 8x RTX Pro 6000:
Modifications
I updated the block sizes to account for the correct amount of smem on these cards. It uses the same setup as the other 100k smem GPU from older generations.
Accuracy Tests
Benchmarking and Profiling
Checklist