Added callback support and as async (requires change to libsignal-protocol-dotnet for it) #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Do we really need the asynchronity? I think it doesn't make that much sense that deep in the stack, especially with the locks around. |
mitchcapper
force-pushed
the
callback_support_for_decrypt_pr
branch
from
5aba4cc to
3b16878
Compare
mitchcapper
force-pushed
the
callback_support_for_decrypt_pr
branch
from
3b16878 to
d5df931
Compare
Contributor
Author
|
Updated Add GetStrippedMessage that takes a SessionRecord instead and use it so callback support on new sessions works. I described this in #18 but didn't submit up the change. |
…tocol-dotnet for it) Add GetStrippedMessage that takes a SessionVersion instead and use it so callback support on new sessions works
mitchcapper
force-pushed
the
callback_support_for_decrypt_pr
branch
from
d5df931 to
bff067d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we didn't want to do async/Task support we could avoid changing the protocol library, (and the library itself has to use .wait as it has locks). This is a bit more future proof / forward planning per the direction it seems you want to be going. Suggest using
?w=1when reviewing the changes to see the content items.signal-csharp/libsignal-protocol-dotnet#5
Closes #18