Add namespace to tesseract images #1792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ko build` names the image after the name of the package that it's building, which in the case of the two tesseract binaries is just "gcp" and "posix", with no context on what those mean. This change extends the KO_DOCKER_REPO variable to include "tesseract" as part of the repo name, so the full image name will have "tesseract" in it. When browsing the scaffolding images, both images will still just appear as "gcp" and "posix". The alternative solution to make them more distinguishable in the web UI would be to use `--preserve-import-paths` which would produce an image named "github.com/transparency-dev/tesseract/cmd/tesseract/gcp", with full name "ghcr.io/sigstore/scaffolding/tesseract/github.com/transparency-dev/tesseract/cmd/tesseract/gcp". Signed-off-by: Colleen Murphy <[email protected]>
haydentherapper
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ko buildnames the image after the name of the package that it's building, which in the case of the two tesseract binaries is just "gcp" and "posix", with no context on what those mean. This change extends the KO_DOCKER_REPO variable to include "tesseract" as part of the repo name, so the full image name will have "tesseract" in it.When browsing the scaffolding images, both images will still just appear as "gcp" and "posix". The alternative solution to make them more distinguishable in the web UI would be to use
--preserve-import-pathswhich would produce an image named"github.com/transparency-dev/tesseract/cmd/tesseract/gcp", with full name
"ghcr.io/sigstore/scaffolding/tesseract/github.com/transparency-dev/tesseract/cmd/tesseract/gcp".
Summary
Release Note
Documentation