Remove unnecessary dependency from Nuget package #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A dotnet restore will try to pull in this unpublished and unneeded package (Discovered while working on coverting FieldWorks to SDK style)
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a dependency issue in the SIL.LCModel.Core.Tests NuGet package by adding the PrivateAssets="All" attribute to the TestHelper project reference to prevent it from being published as a transitive dependency.
- Modified TestHelper project reference to include
PrivateAssets="All"attribute
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mark-sil
approved these changes
Sep 30, 2025
Contributor
mark-sil
left a comment
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jasonleenaylor)
mark-sil
approved these changes
Sep 30, 2025
Contributor
mark-sil
left a comment
mark-sil
left a comment
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A dotnet restore will try to pull in this unpublished and unneeded
package (Discovered while working on coverting FieldWorks to SDK style)
This change is