Update framework to net462 and libPalaso to version 17 #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Needed to move to net462 because libPalaso is net462. Without moving to net462 these 3 tests were failing: InitIcuDataDir_CustomIcuVersion() InitIcuDataDir_FallbackDefaultIcuVersion() InitIcuDataDir_NoIcuLibrary()
jasonleenaylor
approved these changes
Oct 7, 2025
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 19 of 19 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mark-sil)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Needed to move to net462 because libPalaso is net462. Without moving to net462 these 3 tests were failing:
InitIcuDataDir_CustomIcuVersion()
InitIcuDataDir_FallbackDefaultIcuVersion()
InitIcuDataDir_NoIcuLibrary()
This change is