Skip to content

Conversation

@jasonleenaylor
Copy link
Contributor

@jasonleenaylor jasonleenaylor commented Oct 8, 2025

  • In the old build system somehow using the same namespace in the FieldWorks code and in this library was enough to get internal access to the strings resources. Update these strings to public so that FieldWorks can use them in its UI.

This change is Reviewable

 - In the old build system somehow using the same namespace in
   the FieldWorks code and in this library was enough to get internal
   access to the strings resources. Update these strings to public
   so that FieldWorks can use them in its UI.
Copilot AI review requested due to automatic review settings October 8, 2025 19:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes shared string resources public to enable FieldWorks SDK style builds. The change addresses a compatibility issue where the old build system allowed internal access to string resources through namespace sharing, but this no longer works in the new build system.

Key Changes

  • Updated the ResX code generator to produce public string resources instead of internal ones
Files not reviewed (1)
  • src/SIL.LCModel.FixData/Strings.Designer.cs: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jasonleenaylor jasonleenaylor enabled auto-merge (squash) October 8, 2025 19:53
@jasonleenaylor jasonleenaylor merged commit 0bc98fb into master Oct 8, 2025
3 checks passed
@jasonleenaylor jasonleenaylor deleted the chore/exposeFixDataStrings branch October 8, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants