Skip to content

Conversation

@juanjosegzl
Copy link

@juanjosegzl juanjosegzl commented May 26, 2025

Description

On the login url BackURL points to Parent.Link, which causes a bad redirect, e.g. if you are in /about-us the login link takes you back to /

I changed $Parent.Link to $Link

Manual testing steps

Go to a page other than homepage with comments, for example /about-us

The login link originally has BackURL=/

With the change it should show BackURL=/about-us

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • [] This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

On the login url BackURL points to Parent.Link, which causes a bad
redirect, e.g. if you are in /about-us the login link takes you back
to /

I changed $Parent.Link to $Link
@GuySartorelli
Copy link
Member

This module hasn't been in commercial support for a while, and I don't think it currently has any active maintainers.
If you'd like to maintain this module, please email [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants