Fix mypy type errors #248
Open
Fix mypy type errors #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Idk how I feel about changing Hydrant to require older + deprecated packages and version of Python? If anything, it might be better if we figure out how to set up the scripts server to use a modern version of Python |
Contributor
Author
|
@dtemkin1 This is complicated because when I cut out the branch, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes all the remaining mypy type errors as well as most of the "#type: ignore" comments. There is one comment left over which I'd still need to get to, and the
UnionOfDifferentThingsandCoursetypings are inherently pretty loose. However, fixing the latter will probably require reforming the type system repo-wide (including synchronizing with the frontend), and I'm not sure I want to stomach that right now.