SafeTagSupported safe pointer handling #287
Conversation
|
👋 stackman27, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Unheilbar
dismissed stale reviews from 0xAustinWang and silaslenihan
via
a4bfd4e
| if e == nil || e.C == nil || e.C.SafeTagSupported == nil { | ||
| return false | ||
| } |
There was a problem hiding this comment.
Is the default set in the TOML definition? The config tests ensure that these are not left nil.
| if e == nil || e.C == nil || e.C.SafeTagSupported == nil { | |
| return false | |
| } |
There was a problem hiding this comment.
It is set (and the default is actually true FWIW), and I confirmed it comes through as non-nil. In what circumstances did you encounter nil?
There was a problem hiding this comment.
This is the error I'm seeing on staging. Nodes are crashing
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1c3dd67]
goroutine 4242 [running]:
github.com/smartcontractkit/chainlink-evm/pkg/config.(*EVMConfig).SafeTagSupported(0x4?)
/go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/config/chain_scoped.go:116 +0x7
github.com/smartcontractkit/chainlink-framework/chains/heads.(*tracker[...]).LatestSafeBlock(0x81c8ec0, {0x813eab8, 0xc01c4e2500})
/go/pkg/mod/github.com/smartcontractkit/chainlink-framework/[email protected]/heads/tracker.go:407 +0x66
github.com/smartcontractkit/chainlink-evm/pkg/logpoller.(*logPoller).latestSafeBlock(0xc001537860, {0x813eab8?, 0xc01c4e2500?}, 0x43497fc)
/go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/logpoller/log_poller.go:1172 +0x3a
github.com/smartcontractkit/chainlink-evm/pkg/logpoller.(*logPoller).pollAndSaveLogs(0xc001537860, {0x813eab8, 0xc01c4e2500}, 0x4348b7e)
/go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/logpoller/log_poller.go:1061 +0x22a
github.com/smartcontractkit/chainlink-evm/pkg/logpoller.(*logPoller).PollAndSaveLogs(0xc001537860, {0x813eab8?, 0xc01c4e2500?}, 0x0?)
/go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/logpoller/log_poller.go:1032 +0x26
github.com/smartcontractkit/chainlink-evm/pkg/logpoller.(*logPoller).run(0xc001537860)
/go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/logpoller/log_poller.go:665 +0x50a
created by github.com/smartcontractkit/chainlink-evm/pkg/logpoller.(*logPoller).Start.func1 in goroutine 1
/go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/logpoller/log_poller.go:520 +0x69
There was a problem hiding this comment.
Trying to bump staging from this PR: https://github.com/smartcontractkit/infra-k8s/pull/31871/files
the chainlink-evm version in the image is from yesterday: https://github.com/smartcontractkit/chainlink-evm/tree/b2ed6162042f84f7d91b3d588a4a7e616cd1de6f
There was a problem hiding this comment.
@jmank88 is there elsewhere we need to set defaults?
There was a problem hiding this comment.
here's the staging deployment, it seems like the nodes are healthier than earlier but hard to tell without the monitoring
https://argo.main.stage.cldev.sh/applications/cl-ccip-v2-testnet
There was a problem hiding this comment.
It is set in the correct place. Is this value being used without applying the defaults?
5 participants
No description provided.