Let dbt-adapters handle routing to appropriate get_delete_insert_merge_sql macro
#207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge_sql` macro Previously what was being used was `dbt.default_get_delete_insert_merge_sql`. This _always_ got the "default" delete insert merge sql. That was bad because some adapters specifically don't work with the default macro, and implement their own under the hood. By instead using `dbt.get_delete_insert_merge_sql` we allow the "normal" macro resolution to occur.
snowplowcla
added
the
cla:no
|
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
zqureshi
approved these changes
Jun 26, 2025
Author
|
I signed it! |
|
Confirmed! @QMalcolm has signed the Contributor License Agreement. Thanks so much. |
snowplowcla
added
cla:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #204
Description
Previously what was being used was
dbt.default_get_delete_insert_merge_sql. This always got the "default" delete insert merge sql. That was bad because some adapters specifically don't work with the default macro, and implement their own under the hood. By instead usingdbt.get_delete_insert_merge_sqlwe allow the "normal" macro resolution to occur.What type of PR is this? (check all applicable)
Related Tickets & Documents
#204
Checklist
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
No
[optional] What gif best describes this PR or how it makes you feel?