Skip to content

Conversation

@Jack-Keene
Copy link
Contributor

@Jack-Keene Jack-Keene commented Feb 27, 2025

  • Bump Ubuntu versions
  • Drop EoL PHP Versions

@snowplowcla snowplowcla added the cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. label Feb 27, 2025
@coveralls
Copy link

coveralls commented Feb 27, 2025

Coverage Status

coverage: 90.032%. remained the same
when pulling f18888f on release/0.9.0
into 67db749 on master.

Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update the min PHP version in the composer file (and then also the lock file)? That then shows up as a badge in the README.

@Jack-Keene Jack-Keene force-pushed the release/0.9.0 branch 4 times, most recently from 37c6215 to 2f5b341 Compare March 3, 2025 12:47
Jack-Keene and others added 2 commits March 3, 2025 12:52
@Jack-Keene Jack-Keene force-pushed the release/0.9.0 branch 2 times, most recently from 4572d0c to 597d9bb Compare March 3, 2025 12:58
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

composer.json Outdated
"php-coveralls/php-coveralls": "^2.5.2",
"phpunit/php-token-stream": "^4.0.4"
"phpunit/php-token-stream": "^4.0.4",
"symfony/config": "6.4.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last thing to allow for new patch and minor versions:

Suggested change
"symfony/config": "6.4.0",
"symfony/config": "^6.4.0",

@Jack-Keene Jack-Keene merged commit a25ebba into master Mar 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants