-
-
Notifications
You must be signed in to change notification settings - Fork 597
feat(Android, Tabs): Add special effects to bottom tabs on Android #3337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Android, Tabs): Add special effects to bottom tabs on Android #3337
Conversation
kkafar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Only thing I'm worried about is the dismiss model, where we first notify JS & just then dismiss the screens.
I haven't made my mind yet, whether I wanna go this way or not. Will be back soon with more feedback.
android/src/main/java/com/swmansion/rnscreens/gamma/helpers/ViewFinder.kt
Outdated
Show resolved
Hide resolved
e96c62b to
dcd807a
Compare
dcd807a to
f841588
Compare
kkafar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so as we talked, I agree for current dismissal model, but it won't be stable. That is - it might be a subject of change in the future.
I'll revisit the code now & land it soon
kkafar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
FYI: The root cause here is |
We need to update react navigation as we need this fix: react-navigation/react-navigation#12853 to make this PR work properly. Otherwise we encounter error as [reported earlier in the PR](software-mansion#3337 (review)).

Description
Adds special effects to bottom tabs implementation on Android
Screen.Recording.2025-10-24.at.13.34.17.mov
Changes
ViewFinderhelper, which has utils for finding ScrollView and Stack. The implementation is based on iOS one.popToRootmethod toScreenStack. It dispatches dismiss event for every non-root active screen on Stack. It is JS responsibility to remove this screen from stack. This way the dismiss can be prevented.Test code and steps to reproduce
Bottom tabs test app
Checklist