fix(Android, Stack): incorrect header height values #3402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
reviewed
Nov 17, 2025
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Backward compat can be handled via compatibilityFlags in src/flags.ts. This is how we've done it in react navigation so far.
You add a flag there, denoting that a change has been introduced & then try to read it in react navigation. If it is not present or false, you assume old implementation & if it is present & enabled you assume new one.
kkafar
requested changes
Nov 17, 2025
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Thanks for the PR. I've left few remarks.
android/src/main/java/com/swmansion/rnscreens/utils/DimensionUtils.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderHeightUpdateProxy.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes header height values reported via
onHeaderHeightChangeevent.Fixes #3040.
Fixes #2661.
Note
Due to incorrect values being reported previously, there are some workarounds in
react-navigation'sNativeStackView.native.tsx. Those should be redundant now and we should clean-up that code when this PR is merged. We intend to handle backward compatibility through a flag. PR inreact-navigation: react-navigation/react-navigation#12852.before3402.mp4
after3402.mp4
Changes
TestHeaderHeightto allow testing dynamic changes to the prop andreact-navigation'suseHeaderHeight()hookTest code and steps to reproduce
Run
TestHeaderHeight.Checklist