Detect missing frames in ffmpeg_h264
#1536
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noituri
force-pushed
the
@noituri/detect-missed-frames
branch
2 times, most recently
from
47c2b1b to
ad08d8c
Compare
noituri
commented
Nov 19, 2025
Comment on lines
59
to
62
| Err(err) => { | ||
| warn!("Dropping frame: {}", err); | ||
| debug!("H264 AU splitter could not process the chunks: {err}"); | ||
| return Vec::new(); | ||
| } |
Member
Author
There was a problem hiding this comment.
if no frames are returned DynamicVideoDecoderStream will request a keyframe. I don't like that but this will probably be refactored later anyway so I'll leave it as it is
noituri
force-pushed
the
@noituri/detect-missed-frames
branch
9 times, most recently
from
57bbf0e to
affa09c
Compare
noituri
force-pushed
the
@noituri/detect-missed-frames
branch
from
affa09c to
a259210
Compare
Member
|
merged in #1545 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
In this PR I added access unit splitter for
ffmpeg_h264decoder.The access units are checked for missing frames. It only checks the frame nums of nalus and will not work if multiple nalus have the same frame num.
The buffering in the depayloader was disabled because its access unit detection will not work if marker packet is lost