-
Notifications
You must be signed in to change notification settings - Fork 493
Add LiteSVM Tests for Checking Accounts (Anchor) #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sol-warrior
wants to merge
5
commits into
solana-developers:main
Choose a base branch
from
sol-warrior:tests/litesvm-checking-accounts-anchor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
43ac217
feat: add LiteSVM tests for checking accounts functionality
sol-warrior 4f678d4
chore: update TypeScript configuration for checking accounts anchor
sol-warrior 3a8d708
chore: update dependencies for checking accounts anchor
sol-warrior e86a107
chore: add litesvm test script to Anchor.toml
sol-warrior f19e25a
chore: remove unused dependencies and test file for bankrun
sol-warrior File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the test script should work for
tests/litesvm.test.tstooThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review 🙌🏼.
Yes,
litesvm-testis a separate script, but it uses the Node test runner, not Mocha.Running
anchor testwill execute both test suites (litesvm-test.tsandtest.ts).Running
anchor run litesvm-testwill execute only the LiteSVM tests using the Node test runner.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if
litesvm.test.tsis the only test, what's the point of having two scripts that run it.just the test script should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. To clarify: there are two different test files at tests directory with different purposes.
That’s why both scripts currently exist.
If you prefer combining or simplifying them, I can update the PR 🙌🏼