Skip to content

Conversation

@deining
Copy link

@deining deining commented Nov 17, 2024

This PR fixes various typos I spotted in the project.
BOT NOTES:
resolves #539

@solo-build-bot
Copy link

Waiting for approval from someone in the solo-io org to start testing.

ashleywang1
ashleywang1 previously approved these changes Dec 3, 2024
Copy link
Contributor

@ashleywang1 ashleywang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fixes are all valid, and hopefully the changelog bot passes

@jsoref
Copy link

jsoref commented Sep 3, 2025

@ashleywang1 was someone going to merge this PR? (asking because I was considering making a PR, ...)

@solo-changelog-bot
Copy link

Issues linked to changelog:
#539

@deining
Copy link
Author

deining commented Sep 3, 2025

Just rebased my PR.
Also added a changelog file, checker is green now 😄.
Hopefully this PR can be now merged soon!

@deining
Copy link
Author

deining commented Sep 3, 2025

/test

Test run is failing, however that's most likely not introduced by the changes in my PR.

@ashleywang1: can you step in, please?

@jsoref jsoref mentioned this pull request Oct 23, 2025
@jsoref
Copy link

jsoref commented Oct 24, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants