Add support for port media_type #4007
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| db = swsscommon.DBConnector(0, dvs.redis_sock, 0) | ||
| adb = swsscommon.DBConnector(1, dvs.redis_sock, 0) | ||
|
|
||
| tbl = swsscommon.Table(db, "PORT_TABLE") |
Check notice
Code scanning / CodeQL
Unused local variable Note test
Contributor
Author
|
@prgeor @judyjoseph @arlakshm @rlhui for viz |
Contributor
Author
|
@snider-nokia for viz |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
reviewed
Nov 19, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
previously approved these changes
Nov 22, 2025
Contributor
|
@saksarav-nokia vs test is failing...please check if its related to your PR. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saksarav-nokia
force-pushed
the
saksarav-nokia-media-type
branch
from
9c32311 to
cb67d7c
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saksarav-nokia
force-pushed
the
saksarav-nokia-media-type
branch
from
cb67d7c to
f7c52f4
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
previously approved these changes
Nov 26, 2025
Contributor
Author
Contributor
Author
|
@prgeor , the PR failures are not related to my changes and i see all PR's in sonic-swss are failing with the same failures. |
Contributor
Author
|
Created Azure/sonic-swss.msft#173 for msft-202405 |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: saksarav <[email protected]>
Signed-off-by: saksarav <[email protected]>
Signed-off-by: saksarav <[email protected]>
saksarav-nokia
force-pushed
the
saksarav-nokia-media-type
branch
from
1088eb4 to
fa531cb
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: saksarav <[email protected]>
saksarav-nokia
force-pushed
the
saksarav-nokia-media-type
branch
from
fa531cb to
b9df981
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added support to parse the media_type set in PORT_TABLE in APP_DB and set the corresponding SAI attribute in SAI
Why I did it
media_type support was not present in sonic-swss
How I verified it
Added the media_type in media_settings.json file and verified that they are passes to swss, SAI and also got programmed in the Asic. The verification was done in Nokia chassis platform.
Details if related