Skip to content

Fix assertion failure in saveQualifierReferences #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jupblb wants to merge 2 commits into
base: scip-ruby/master
Choose a base branch
from
Open

Fix assertion failure in saveQualifierReferences #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c72464e
Fix assertion failure in saveQualifierReferences
jupblb Nov 21, 2025
1d50957
Add regression test for inheritance crash
jupblb Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scip_indexer/SCIPIndexer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ class SCIPState {
ast::ExpressionPtr &constantLitExpr) {
auto *expr = &constantLitExpr;
while (auto *constantLit = ast::cast_tree<ast::ConstantLit>(*expr)) {
if (constantLit->symbol.exists() && constantLit->symbol.asClassOrModuleRef().exists()) {
if (constantLit->symbol.exists() && constantLit->symbol.isClassOrModule() && constantLit->symbol.asClassOrModuleRef().exists()) {
core::Context ctx(gs, constantLit->symbol, file);
auto status = this->saveReference(ctx, GenericSymbolRef::classOrModule(constantLit->symbol),
/*overrideType*/ std::nullopt, constantLit->loc, 0);
Expand Down
4 changes: 4 additions & 0 deletions test/scip/testdata/inheritance.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,7 @@ def write_f_plus_1(a)
end
end

Z5 = Object
class Z6 < Z5
end

9 changes: 9 additions & 0 deletions test/scip/testdata/inheritance.snapshot.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,12 @@ def write_f_plus_1(a)
end
end

Z5 = Object
#^^ definition [..] Z5.
#relation reference=[..] Object#
#^^^^^^^^^^^ reference [..] Z5.
# ^^^^^^ reference [..] Object#
class Z6 < Z5
# ^^ definition [..] Z6#
end

Loading