-
Notifications
You must be signed in to change notification settings - Fork 18
Re-export some useful items #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e10ff9e to
062085f
Compare
itowlson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to update samples that use these as part of this PR, or punt to a follow-up? )I am fine with punting, just flagging the thought.)
|
YES. I knew i immediately forgot something that i had planned to do 😆 |
Signed-off-by: Brian Hardock <[email protected]>
062085f to
bdcad42
Compare
|
I think I got em' all. |
itowlson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not all then it's an easy follow-up
|
|
||
| pub use wasip3::{ | ||
| http_compat::{IncomingMessage, Request, Response}, | ||
| wit_bindgen::{self, spawn}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the train has already left the station, but re-exporting wasip3 which itself includes all of wit_bindgen makes backwards compat very difficult. We're tying ourselves to the exact public API of two external crates. Maybe that's unavoidable...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think wit-bindgen is effectively "std-like" for async Rust guests. wasip3 is a little different but we have to at least secretly re-export it to make #[http_service] work.
No description provided.