Skip to content

Conversation

@fibonacci1729
Copy link
Contributor

No description provided.

Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to update samples that use these as part of this PR, or punt to a follow-up? )I am fine with punting, just flagging the thought.)

@fibonacci1729
Copy link
Contributor Author

YES. I knew i immediately forgot something that i had planned to do 😆

Signed-off-by: Brian Hardock <[email protected]>
@fibonacci1729
Copy link
Contributor Author

fibonacci1729 commented Nov 12, 2025

I think I got em' all.

@fibonacci1729 fibonacci1729 merged commit 69814cd into main Nov 12, 2025
3 checks passed
@fibonacci1729 fibonacci1729 deleted the reexports branch November 12, 2025 19:31
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not all then it's an easy follow-up


pub use wasip3::{
http_compat::{IncomingMessage, Request, Response},
wit_bindgen::{self, spawn},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the train has already left the station, but re-exporting wasip3 which itself includes all of wit_bindgen makes backwards compat very difficult. We're tying ourselves to the exact public API of two external crates. Maybe that's unavoidable...

Copy link
Contributor

@lann lann Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think wit-bindgen is effectively "std-like" for async Rust guests. wasip3 is a little different but we have to at least secretly re-export it to make #[http_service] work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-export common wasip3 items from root module

5 participants