Skip to content

Conversation

@quaff
Copy link
Contributor

@quaff quaff commented Nov 19, 2025

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 19, 2025
@sbrannen sbrannen requested a review from bclozel November 19, 2025 10:06
@sbrannen sbrannen added the type: task A general task label Nov 19, 2025
@ChildrenGreens
Copy link

I am seeing the same MultiReleaseJarPluginTests.validateJar() failure on a non-English Windows environment.

Environment:

  • OS: Windows 11 (zh_CN)
  • JDK: 25 (C:\Program Files\Java\jdk-25)
  • Console encoding: GBK

The error message printed by the validateMultiReleaseJar task is localized and garbled, for example:

Task :validateMultiReleaseJar FAILED
��Ŀ META-INF/versions/17/Main.class ����������������ڰ汾��ͬ�� api

Because of this, the assertion

assertThatThrownBy(...).hasMessageContaining(
    "entry: META-INF/versions/17/Main.class, contains a class with different api from earlier version"
);

does not match, and the test fails.

This PR makes sense to me since it forces user.language=en for the TestKit build and should fix the issue for non-English locales as well.

@bclozel bclozel merged commit e0353fe into spring-projects:main Nov 19, 2025
3 checks passed
@bclozel bclozel self-assigned this Nov 19, 2025
@bclozel bclozel removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 19, 2025
@bclozel bclozel added this to the 7.0.1 milestone Nov 19, 2025
@bclozel
Copy link
Member

bclozel commented Nov 19, 2025

Thanks @quaff !

@bclozel bclozel removed their request for review November 19, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants