Hardware pins to telemetry_task.c, SAMWISE_FIXED_SOLAR_CHARGE state is reversed (fixes #86) #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.3
Click here for the full clang-format patch
diff --git a/src/init/init.c b/src/init/init.c
index d097fdc..f602ffb 100644
--- a/src/init/init.c
+++ b/src/init/init.c
@@ -93 +93 @@ bool init(slate_t *slate)
-
+
@@ -99 +99 @@ bool init(slate_t *slate)
-
+
@@ -102 +102 @@ bool init(slate_t *slate)
-
+
@@ -105 +105 @@ bool init(slate_t *slate)
-
+
@@ -108 +108 @@ bool init(slate_t *slate)
-
+
@@ -111 +111 @@ bool init(slate_t *slate)
-
+
Have any feedback or feature suggestions? Share it here.
microbites0
changed the title
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.3
Click here for the full clang-format patch
diff --git a/src/init/init.c b/src/init/init.c
index 88a4c92..c9d190c 100644
--- a/src/init/init.c
+++ b/src/init/init.c
@@ -98 +98 @@ bool init(slate_t *slate)
-
+
@@ -101 +101 @@ bool init(slate_t *slate)
-
+
@@ -104 +104 @@ bool init(slate_t *slate)
-
+
@@ -107 +107 @@ bool init(slate_t *slate)
-
+
@@ -110 +110 @@ bool init(slate_t *slate)
-
+
Have any feedback or feature suggestions? Share it here.
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.3
Click here for the full clang-format patch
diff --git a/src/init/init.c b/src/init/init.c
index 67ab826..a6949f8 100644
--- a/src/init/init.c
+++ b/src/init/init.c
@@ -100 +100 @@ bool init(slate_t *slate)
-
+
@@ -103 +103 @@ bool init(slate_t *slate)
-
+
@@ -106 +106 @@ bool init(slate_t *slate)
-
+
@@ -109 +109 @@ bool init(slate_t *slate)
-
+
Have any feedback or feature suggestions? Share it here.
src/init/init.c
Outdated
|
|
||
| gpio_init(SAMWISE_PANEL_A); | ||
| gpio_set_dir(SAMWISE_PANEL_A, GPIO_IN); | ||
|
|
Contributor
There was a problem hiding this comment.
clang-format suggestion
Suggested change
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.3
Only 2 out of 3 clang-format concerns fit within this pull request's diff.
Click here for the full clang-format patch
diff --git a/src/init/init.c b/src/init/init.c
index c2a45ae..a0c9afe 100644
--- a/src/init/init.c
+++ b/src/init/init.c
@@ -102 +102 @@ bool init(slate_t *slate)
-
+
@@ -105 +105 @@ bool init(slate_t *slate)
-
+
@@ -108 +108 @@ bool init(slate_t *slate)
-
+
Have any feedback or feature suggestions? Share it here.
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.3
Click here for the full clang-format patch
diff --git a/src/init/init.c b/src/init/init.c
index 2eb8b05..1bc3d53 100644
--- a/src/init/init.c
+++ b/src/init/init.c
@@ -104 +104 @@ bool init(slate_t *slate)
-
+
@@ -107 +107 @@ bool init(slate_t *slate)
-
+
Have any feedback or feature suggestions? Share it here.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.3
Click here for the full clang-format patch
diff --git a/src/init/init.c b/src/init/init.c
index 7ca1077..3f987ac 100644
--- a/src/init/init.c
+++ b/src/init/init.c
@@ -106 +106 @@ bool init(slate_t *slate)
-
+
Have any feedback or feature suggestions? Share it here.
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.3
Click here for the full clang-format patch
diff --git a/src/init/init.c b/src/init/init.c
index 0fcd440..612f0e7 100644
--- a/src/init/init.c
+++ b/src/init/init.c
@@ -105 +105 @@ bool init(slate_t *slate)
-
+
Have any feedback or feature suggestions? Share it here.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.3
Click here for the full clang-format patch
diff --git a/src/init/init.c b/src/init/init.c
index 792ffb3..13d3983 100644
--- a/src/init/init.c
+++ b/src/init/init.c
@@ -103 +103 @@ bool init(slate_t *slate)
-
+
Have any feedback or feature suggestions? Share it here.
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.3
Click here for the full clang-format patch
diff --git a/src/init/init.c b/src/init/init.c
index 4c50599..bb5402f 100644
--- a/src/init/init.c
+++ b/src/init/init.c
@@ -104 +104 @@ bool init(slate_t *slate)
-
+
Have any feedback or feature suggestions? Share it here.
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.3
Click here for the full clang-format patch
diff --git a/src/init/init.c b/src/init/init.c
index 10f5bca..cf457e7 100644
--- a/src/init/init.c
+++ b/src/init/init.c
@@ -102 +102 @@ bool init(slate_t *slate)
-
+
Have any feedback or feature suggestions? Share it here.
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.3
Click here for the full clang-format patch
diff --git a/src/init/init.c b/src/init/init.c
index 7c1e327..f446a61 100644
--- a/src/init/init.c
+++ b/src/init/init.c
@@ -102,3 +102 @@ bool init(slate_t *slate)
- * Initialize gpio pins
- */
- ASSERT(init_gpio_pins());
+ *Initialize gpio pins * / ASSERT(init_gpio_pins());
Have any feedback or feature suggestions? Share it here.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.3
Click here for the full clang-format patch
diff --git a/src/init/init.c b/src/init/init.c
index 9b9f34d..609a652 100644
--- a/src/init/init.c
+++ b/src/init/init.c
@@ -102,2 +102 @@ bool init(slate_t *slate)
- * Initialize gpio pins
- ASSERT(init_gpio_pins());
+ *Initialize gpio pins ASSERT(init_gpio_pins());
Have any feedback or feature suggestions? Share it here.
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.3
Click here for the full clang-format patch
diff --git a/src/init/init.c b/src/init/init.c
index 8ee736a..f9881d0 100644
--- a/src/init/init.c
+++ b/src/init/init.c
@@ -102,3 +102 @@ bool init(slate_t *slate)
- * Initialize gpio pins
- ASSERT(init_gpio_pins());
-
+ *Initialize gpio pins ASSERT(init_gpio_pins());
Have any feedback or feature suggestions? Share it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86
Changed CHRG_STATUS (PIN 34) logic from LOW to HIGH.
Per issue #86 discussion, CHRG on + FAULT off indicates normal charging:
Also initialized hardware pins in init.c and updated slate in telemetry_task.c