feat(dapp-browser-ens)_: integrate browserBridge to BrowserLayout #19151
+282
−265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (72)
|
friofry
force-pushed
the
ab/issue-18545-connector-backend-5
branch
from
c784dbb to
39a6365
Compare
friofry
force-pushed
the
ab/issue-18545-connector-backend-5
branch
3 times, most recently
from
df3a72e to
97d7016
Compare
friofry
changed the base branch from
ab/issue-18545-connector-backend-4
to
ab/issue-18545-connector-backend-3
friofry
force-pushed
the
ab/issue-18545-connector-backend-5
branch
from
97d7016 to
6853960
Compare
friofry
changed the base branch from
ab/issue-18545-connector-backend-3
to
ab/issue-19188-change-account-api
friofry
force-pushed
the
ab/issue-19188-change-account-api
branch
from
5d3b34d to
f02bff9
Compare
friofry
force-pushed
the
ab/issue-18545-connector-backend-5
branch
2 times, most recently
from
82b65db to
d002497
Compare
friofry
requested review from
a team,
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
caybro
reviewed
Nov 6, 2025
Member
caybro
left a comment
caybro
left a comment
There was a problem hiding this comment.
Needs fixing the ui-tests:
[2025-10-31T14:16:44.175Z] 1: >>> StoryBook page verification failed with 1 errors.
[2025-10-31T14:16:44.175Z] 1: >>> StoryBook pages with errors: QList("/home/jenkins/workspace/linux_x86_64_tests-ui_PR-19151_2/storybook/pages/BrowserLayoutPage.qml")
7bba9d9 to
226e435
Compare
friofry
force-pushed
the
ab/issue-18545-connector-backend-5
branch
2 times, most recently
from
36c4ce8 to
f6db4b8
Compare
friofry
force-pushed
the
ab/issue-18545-connector-backend-5
branch
from
9cffdde to
b8544f5
Compare
Contributor
Author
Done ✅ |
friofry
force-pushed
the
ab/issue-19188-change-account-api
branch
from
226e435 to
bf01f81
Compare
friofry
force-pushed
the
ab/issue-18545-connector-backend-5
branch
from
b8544f5 to
4903151
Compare
alexjba
approved these changes
Nov 11, 2025
| } | ||
| } | ||
|
|
||
| onJavaScriptConsoleMessage: function(level, message, lineNumber, sourceID) { |
Contributor
There was a problem hiding this comment.
Can we get a setup with dapp logs as well? It's usually very useful when debugging the dapp interaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19141
flowchart LR step1["Connector service<br/>#19113"] --> step2["QML bridge<br/>#19131"] step2 --> step3["Cleanup old provider<br/>#19133"] step3 --> step4["Account Change<br/>#19188"] step4 --> step5["Integrate Bridge<br/>#19151"] style step5 fill:#4dabf7,stroke:#1864ab,stroke-width:4px,color:#fff,font-weight:boldConnectorBridgecomponent, replacing localWebEngineProfileinstances with centralized connector profiles; added dApp URL metadata updates on navigationonRequestInternal)request()method with internal signal routing and async response handlingconnectorControllerto BrowserLayout