-
Notifications
You must be signed in to change notification settings - Fork 90
chore(ci): nuke unused android gh action #19238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jenkins BuildsClick to see older builds (43)
|
6f4002a to
f21a751
Compare
|
cc @glitchminer - in case you're still using this GH action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to remove, test mode is available via Jenkins now.
f21a751 to
840f6d5
Compare
for PRs we use ci/Jenkinsfile.android, if you wish to perform a manual android build you may use https://ci.status.im/job/status-desktop/job/systems/job/android/job/arm64/job/package/build?delay=0sec
840f6d5 to
b7861ef
Compare
| touch $(TARGET) | ||
| @echo "Building $(TARGET) for architecture $(ARCH) using Docker image $(DOCKER_IMAGE)" | ||
| @mkdir -p $(BIN_PATH) | ||
| @docker run --rm \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's just terrible. If we want to do that we should run whole of mobile/ContainerBuilds.mk inside a container and not modify this makefile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh i see what you mean, I can make that change, change to this file was needed to get rid of reference to .github/workflows/android-build.yml
|
Also, the title of the PR and commit do not reflect the most important change made. |
Summary
for PRs we use
ci/Jenkinsfile.android, if you wish to perform a manual android build you may usehttps://ci.status.im/job/status-desktop/job/systems/job/android/job/arm64/job/package/build?delay=0sec