feat: add EFP (Ethereum Follow Protocol) integration for wallet #7052
+597
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
1 task
caveman-eth
changed the title
Collaborator
Author
jrainville
requested review from
Khushboo-dev-cpp,
dlipicar,
igor-sirotin and
jrainville
jrainville
approved these changes
Nov 7, 2025
Member
jrainville
left a comment
jrainville
left a comment
There was a problem hiding this comment.
Awesome work! Looks very good.
You'll have to rebase and fix some lint issues I think
Member
|
ah, also commits need to follow conventional commit format, eg |
Collaborator
|
@caveman-eth I have sent you an Github invite for collaborator. Please accept and rebase to trigger the CI 🙂 |
Member
Jenkins BuildsClick to see older builds (17)
|
Introduces Ethereum Follow Protocol (EFP) integration for fetching following addresses and stats. Adds a following manager, EFP client, and related API endpoints, along with tests for both manager and client functionality.
Changed the go:generate directive to explicitly use 'go tool mockgen' instead of just 'mockgen' for generating mocks. This may improve compatibility or clarity in environments where the tool is not globally installed.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #7052 +/- ##
===========================================
- Coverage 59.68% 59.63% -0.05%
===========================================
Files 804 806 +2
Lines 114076 114249 +173
===========================================
+ Hits 68081 68129 +48
- Misses 39066 39159 +93
- Partials 6929 6961 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Collaborator
Author
Great, looks like everything is passing now
I think everything is right now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for fetching and managing Ethereum Follow Protocol (EFP) followings in the wallet service
Relating to: status-im/status-desktop#18686
and status-desktop PR: status-im/status-desktop#19195
Screenshot:
Complete video demo:
https://streamable.com/3y4s1f
Changes:
New EFP Client (
services/wallet/thirdparty/efp/):/searchFollowingendpointFollowing Manager (
services/wallet/following/):RPC API (
services/wallet/api.go):wallet_GetFollowingAddresses(userAddress, search, limit, offset)- fetch following addresses with optional search and paginationwallet_GetFollowingStats(userAddress)- get total following countTests:
client_test.go- 6 unit tests for HTTP client (pagination, search, stats, error handling)manager_test.go- 5 unit tests for manager (success cases, provider errors, edge cases)API Endpoints Used
GET /users/{address}/following?include=ens&limit={limit}&offset={offset}&sort=latestGET /users/{address}/searchFollowing?include=ens&sort=latest&term={search}GET /users/{address}/stats